Again, this is a broken API only on 3.0.x branch, trunk is fine.

Brian

On Thu, Feb 9, 2012 at 9:30 AM, Brian Geffon <briangef...@gmail.com> wrote:

> Nick,
> Are you on the 3.0.x branch because I just did:
>
> bgeffon-mn:trafficserver bgeffon$ git pull
> Already up-to-date.
> bgeffon-mn:trafficserver bgeffon$ git branch -a
> * 3.0.x
>   master
>   remotes/origin/2.0.x
>   remotes/origin/3.0.x
>   remotes/origin/HEAD -> origin/master
>   remotes/origin/dev
>   remotes/origin/ipv6
>   remotes/origin/master
>   remotes/origin/ssc
>   remotes/origin/ssd
>   remotes/origin/wccp
> bgeffon-mn:trafficserver bgeffon$ git checkout origin/3.0.x
> Note: checking out 'origin/3.0.x'.
>
> HEAD is now at b45fa57... backport r1236880 /
> 5ea619b2a10d22f3d17ea70fb5c7bb5bac954eea TS-1066
> TSHttpTxnServerReqHdrBytesGet in InkAPI.cc has an extra parameter (int
> *bytes) from the prototype in <ts/ts.h>. Author: Alistair Stevenson review:
> zwoop, igalic, niq backport: igalic
> bgeffon-mn:trafficserver bgeffon$ vi STATUS
> bgeffon-mn:trafficserver bgeffon$ cat proxy/InkAPI.cc | grep TSFetchUrl
> TSFetchUrl(const char* headers, int request_len, unsigned int ip, int port
> , TSCont contp, TSFetchWakeUpOptions callback_options,TSFetchEvent events)
>
>
>
> Brian
>
> On Thu, Feb 9, 2012 at 9:23 AM, Nick Kew <n...@apache.org> wrote:
>
>>
>> On 9 Feb 2012, at 16:31, Brian Geffon wrote:
>>
>> > Nick,
>> >
>> > Look at InkAPC.cc in 3.0.x that declaration in ts.h.in doesn't match
>> > the definition, that's the problem.
>>
>>
>> $ grep TSFetchUrl proxy/api/ts/ts.h.in
>> [...]
>>  tsapi void TSFetchUrl(const char* request,int request_len, struct
>> sockaddr const* addr, TSCont contp, TSFetchWakeUpOptions
>> callback_options,TSFetchEvent event);
>> [...]
>>
>> $ grep TSFetchURL proxy/InkAPI.cc
>> [...]
>> TSFetchUrl(const char* headers, int request_len, sockaddr const* ip ,
>> TSCont contp, TSFetchWakeUpOptions callback_options,TSFetchEvent events)
>>
>> The proposed patch appears to want to change away from that!
>>
>> --
>> Nick Kew
>
>
>

Reply via email to