----- Original Message ----- > > On 9 Feb 2012, at 11:57, Nick Kew wrote: > > > I'll post my patch here so as not to delay it while I find my way > > into ASF git. > > Looks like the listserver stripped out the attachment. Inlining ... > > > ++++ > Index: STATUS > =================================================================== > --- STATUS (revision 1242254) > +++ STATUS (working copy) > @@ -57,22 +57,23 @@ > *) Build: Add possibility to extend tsxs command line for > -Iincludes. > Trunk patch: http://svn.apache.org/viewvc?view=rev&rev=1212075 > Jira: https://issues.apache.org/jira/browse/TS-1046 > - +1: igalic, zwoop > + +1: igalic, zwoop, niq > > *) Management: traffic_line -r returns "Variable Not Found", even > if it's a permission issue > Trunk patch: http://svn.apache.org/viewvc?view=rev&rev=1181096 > Jira: https://issues.apache.org/jira/browse/TS-830 > +1: igalic, zwoop > + niq says: is this the intended change to NetworkUtilsRemote.cc? > > *) API: Wrong implementation of TSHttpSsnArgGet(). > Trunk patch: http://svn.apache.org/viewvc?view=rev&rev=1220600 > Jira: https://issues.apache.org/jira/browse/TS-1055 > - +1: zwoop > + +1: zwoop, niq > > *) HttpSM: slow log can not print logs well on 32-bit system. > Trunk patch: http://svn.apache.org/viewvc?view=rev&rev=1225944 > Jira: https://issues.apache.org/jira/browse/TS-1014 > - +1: zwoop, igalic > + +1: zwoop, igalic, niq > > *) Traffic Cop: segment fault when TRACE_LOG_COP is enabled > Trunk patch: http://svn.apache.org/viewvc?view=rev&rev=1225724 > @@ -82,7 +83,10 @@ > *) HttpSM: TS can hang on HTTPS POST requests. > Trunk patch: http://svn.apache.org/viewvc?view=rev&rev=1228988 > Jira: https://issues.apache.org/jira/browse/TS-1049 > - +1: zwoop > + +1: zwoop, niq > + niq comments: This patch combines the bugfix with no-op > stylistic > + changes. Not a big deal for a simple change, but > in > + general it risks complicating review.
This is the only thing that actually applies against our git 3.0.x branch. I'll commit it for you. I'll commit the other votes as well, when I have more cycles, unless you beat me to it. I'd also like to add that I fully agree, and I'm very glad zwoop has dropped his terrible habit of making reviews a pain with whitespace changes :) (this is actually thanks to git!) i > *) PluginVC should schedule to the local queue instead of the > external queue. > Trunk patch: > http://svn.apache.org/viewvc?view=revision&revision=1228526 > @@ -97,7 +101,7 @@ > *) API: TSHttpTxnServerReqHdrBytesGet in InkAPI.cc has an extra > param. > Trunk patch: http://svn.apache.org/viewvc?view=rev&rev=1236880 > Jira: https://issues.apache.org/jira/browse/TS-1061 > - +1: zwoop > + +1: zwoop, niq > > *) forward map based on request receive port > Trunk patch: (see TS876.fixed.patch in JIRA) > @@ -108,6 +112,7 @@ > Trunk patch: (patch only applies to 3.0.x, see JIRA) > Jira: https://issues.apache.org/jira/browse/TS-1095 > +1: briang > + -1: niq: confused, TSFetchURL looks fine in what I see with 3.0.x > identical to trunk > > RELEASE PROCESS > ---- > > -- > Nick Kew -- Igor Galić Tel: +43 (0) 664 886 22 883 Mail: i.ga...@brainsware.org URL: http://brainsware.org/ GPG: 6880 4155 74BD FD7C B515 2EA5 4B1D 9E08 A097 C9AE
