On 2/8/12 11:18 PM, James Peach wrote:
On 08/02/2012, at 9:02 PM, James Peach wrote:
Hi all,
In getNumSSLThreads(), there is the following comment:
// Set number of ssl threads equal to num of processors if
// SSL is enabled so it will scale properly. If SSL is not
// enabled, leave num of ssl threads one, incase a remap rule
// requires traffic server to act as an ssl client.
However, if SSL is not enabled. getNumSSLThreads() returns 0. In this case,
SSLNetProcessor::start() will fail.
So is the code wrong or is the commend wrong?
I think that might be me doing it. I have a vague recollection of turning
off the SSLprocessor if SSL is not enabled. It seemed (at the time at
least) illogical to start the SSLprocessor with SSL disabled. It's probably
Ok to always start it up, it ought to be marginal overhead (memory, CPU etc.).
Not sure how you plan on enabling this, I think your ideas are sound (I
agree that "automation" is better then "manual", in fact, that's one of our
strength, e.g. how we auto scale net-threads). It just might be difficult
since plugins are loaded much later.
Cheers,
-- leif
