On 08/22/2010 11:37 PM, Mladen Turk wrote:
On 08/23/2010 04:35 AM, zw...@apache.org wrote:
Author: zwoop
Author: Yakov Markovitch
Review and minor changes: Leif

if (is_action_tag_set("deft") || is_action_tag_set("sdk_vbos_errors")) {

If va_start/va_end is used multiple times within a function,
va_copy should be used thought.

Is that really worth it? This case is an extremely verbose debug mode anyways, so performance can't be an issue. And the man-page clearly indicates that it's OK to call va_start() / va_end() multiple times:

"Multiple traversals of the list, each bracketed by va_start() and va_end() are possible."


But, if the consensus is that we ought to use va_copy(), I have no problems fixing this patch.

-- leif

Reply via email to