On 05/25/2010 08:33 AM, Mladen Turk wrote:
On 05/25/2010 04:02 PM, Leif Hedstrom wrote:
That much said, there might be one or two plugins in the examples
directory that ought to get moved over to the "official" plugin
directory. I know Steve wrote a little Remap Plugin that I think could
be useful for users, and it is currently in the examples directory.
Perhaps we can adopt the Httpd's concept of standard and experimental
(plugins instead modules)
Each "experimental" would have to be explicitly enabled at configure
time, e.g. --enable-foo-plugin and then it'll be part of 'make install'
otherwise it'll be skipped unlike "stable" plugins which will need
--disable-bar-plugin to get ruled out.
The discussions we've had so far sort of leaned towards leaving plugins
out of the "core". I.e. each production quality would have its own
"package" and release cycle. That might change if/when we manage to
modularize the core of ATS further, e.g. isolate existing code like ICP
into a plugin, and have that part of regular releases.
I'm fairly certain we never want to have "production" plugins in the
example directory though. As I said, they are there to illustrate code
examples as documented in the SDK docs, not to be used by users (at
least not without heavy customizations).
The one exception I can think of is examples/query_remap, which lets you
"route" traffic based on query parameters. But it would still need some
more work to make it "packageble".
I think the idea was to keep plugins in a separate directory. We
currently have
http://svn.apache.org/repos/asf/trafficserver/plugins/
but there is nothing in there, so I'm ok moving it somewhere else (but
not in "example").
At a minimum I think we should eliminate the 'example' directory from
the "make install" target, and I'm +1 on Mladen's suggestion of creating
a new target (or two) for "make example" (and maybe "make
example-install" that would install in libexec).
-- leif
