I have a few thoughts:

 

* What about non-class member variables? In the code, it seems like they
are not camel-cased, but underscore separated. Shall we continue to
follow this? I'm asking this because class member variables will be
camel-cased.

 

* From the example, it seems like '*' is associated with the variable
and not the type, i.e., 'char *arg' and not 'char* arg'. Can we state
this explicitly and also clarify whether this applies to references
also?

 

* In the example, should 'ts' in 'namespace ts' also be camel-cased to
'Ts'?

 

- Manjesh

 

 

 

________________________________

From: Leif Hedstrom [mailto:zw...@apache.org] 
Sent: Wednesday, December 09, 2009 3:26 PM
To: Manjesh Nilange
Subject: Fwd: coding style

 



-------- Original Message -------- 

Subject: 

coding style

Date: 

Wed, 9 Dec 2009 15:23:41 -0800

From: 

Bryan Call <bc...@yahoo-inc.com> <mailto:bc...@yahoo-inc.com> 

Reply-To: 

trafficserver-dev@incubator.apache.org

To: 

trafficserver-dev@incubator.apache.org

 

I would like to open up a discussion about coding style...
 
I updated the coding style wiki because there was some confusion around
method naming and private method naming.
 
http://cwiki.apache.org/confluence/display/TS/Coding+Style
 
We are pretty strict on our indentation and we need to be more strict on
our class, method, and member names to insure consistency in the code.
Unfortunately there is no good tool to automate consistency like there
is for indentation.
 
-Bryan

Reply via email to