[
https://issues.apache.org/jira/browse/TIKA-4993?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=18130897#comment-18130897
]
ASF GitHub Bot commented on TIKA-4993:
--------------------------------------
Copilot commented on code in PR #3405:
URL: https://github.com/apache/tika/pull/3405#discussion_r4359700650
##########
tika-parsers/tika-parsers-standard/tika-parsers-standard-modules/tika-parser-microsoft-module/src/main/java/org/apache/tika/parser/microsoft/ooxml/XSSFExcelExtractorDecorator.java:
##########
Review Comment:
`@Override` on the `cell(..., XSSFComment)` overload is likely to fail
compilation after upgrading to POI 6.0.0 if the upstream `SheetContentsHandler`
method signature changed to `cell(..., org.apache.poi.ss.usermodel.Comment)`.
If this method no longer overrides anything in POI 6, remove `@Override` (or
otherwise ensure it still matches an implemented interface). Keeping
`@Deprecated` is fine if you still want the backward-compatible overload.
##########
tika-parsers/tika-parsers-standard/tika-parsers-standard-modules/tika-parser-microsoft-module/src/main/java/org/apache/tika/parser/microsoft/ooxml/XSSFExcelExtractorDecorator.java:
##########
Review Comment:
The opening brace placement for this new method is inconsistent with
surrounding methods in this class (braces appear on the same line elsewhere).
Aligning formatting here improves consistency and avoids potential
style/checkstyle violations.
> Update to POI 6.0.0
> -------------------
>
> Key: TIKA-4993
> URL: https://issues.apache.org/jira/browse/TIKA-4993
> Project: Tika
> Issue Type: Improvement
> Components: parser
> Reporter: Tilman Hausherr
> Priority: Minor
>
--
This message was sent by Atlassian Jira
(v10.3.26#10030026)
