[
https://issues.apache.org/jira/browse/TIKA-4993?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=18130928#comment-18130928
]
ASF GitHub Bot commented on TIKA-4993:
--------------------------------------
THausherr commented on code in PR #3405:
URL: https://github.com/apache/tika/pull/3405#discussion_r4360138485
##########
tika-parsers/tika-parsers-standard/tika-parsers-standard-modules/tika-parser-microsoft-module/src/main/java/org/apache/tika/parser/microsoft/ooxml/XSSFExcelExtractorDecorator.java:
##########
@@ -1084,19 +1088,10 @@ public void cell(String cellRef, String formattedValue,
}
}
- /**
- * Bridge for POI's {@link SheetContentsHandler} interface, used by the
- * XLSB (binary) path via {@link
org.apache.poi.xssf.binary.XSSFBSheetHandler}.
- */
+ @Override
+ @Deprecated
public void cell(String cellRef, String formattedValue, XSSFComment
comment) {
- XSSFCommentsShim.CommentData commentData = null;
- if (comment != null) {
- String text = comment.getString() != null ?
- comment.getString().getString() : "";
- commentData = new XSSFCommentsShim.CommentData(
- comment.getAuthor(), text);
- }
- cell(cellRef, formattedValue, commentData);
+ cell(cellRef, formattedValue, (Comment) comment);
}
Review Comment:
This is found in the super class
> Update to POI 6.0.0
> -------------------
>
> Key: TIKA-4993
> URL: https://issues.apache.org/jira/browse/TIKA-4993
> Project: Tika
> Issue Type: Improvement
> Components: parser
> Reporter: Tilman Hausherr
> Priority: Minor
>
--
This message was sent by Atlassian Jira
(v10.3.26#10030026)
