[
https://issues.apache.org/jira/browse/TIKA-4985?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=18129639#comment-18129639
]
ASF GitHub Bot commented on TIKA-4985:
--------------------------------------
tballison commented on code in PR #3377:
URL: https://github.com/apache/tika/pull/3377#discussion_r4337014026
##########
tika-parsers/tika-parsers-standard/tika-parsers-standard-modules/tika-parser-pkg-module/src/test/java/org/apache/tika/parser/pkg/RarParserTest.java:
##########
@@ -92,6 +99,25 @@ public void testEmbedded() throws Exception {
assertContains("test-documents/testXML.xml", content);
}
+ @Test
+ public void testCorruptEntryKeepsLaterEntries(@TempDir Path tmp) throws
Exception {
+ byte[] rar;
+ try (TikaInputStream tis =
getResourceAsStream("/test-documents/test-documents.rar")) {
+ rar = IOUtils.toByteArray(tis);
+ }
+ // testEXCEL.xls, the first entry, has its packed data at 80..2885
+ rar[1500] ^= 0x5A;
+ Path corrupt = tmp.resolve("corrupt.rar");
+ Files.write(corrupt, rar);
+
+ List<Metadata> metadataList = getRecursiveMetadata(corrupt, new
ParseContext(), false);
+
assertNotNull(metadataList.get(0).get(TikaCoreProperties.TIKA_META_EXCEPTION_EMBEDDED_STREAM));
+ assertContains("test-documents/testXML.xml",
+ metadataList.get(0).get(TikaCoreProperties.TIKA_CONTENT));
+ assertEquals("/testXML.xml",
+ metadataList.get(metadataList.size() -
1).get(TikaCoreProperties.EMBEDDED_RESOURCE_PATH));
Review Comment:
Yep. Fixed.
> Prep for 4.2.0 release
> ----------------------
>
> Key: TIKA-4985
> URL: https://issues.apache.org/jira/browse/TIKA-4985
> Project: Tika
> Issue Type: Task
> Reporter: Tim Allison
> Priority: Major
>
> From the first round: junrar changed exception handling. The updated zip bomb
> detection triggers on compressed log files, and a few other fixes. Vast
> majority of content is unchanged. the mhtml change didn't do much. The html
> detection change is a clear improvement.
>
> Will run round two later today and post results if they're good enough for an
> rc1.
--
This message was sent by Atlassian Jira
(v8.20.10#820010)
