[
https://issues.apache.org/jira/browse/TIKA-4393?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17935269#comment-17935269
]
ASF GitHub Bot commented on TIKA-4393:
--------------------------------------
tballison opened a new pull request, #2163:
URL: https://github.com/apache/tika/pull/2163
<!--
Licensed to the Apache Software Foundation (ASF) under one
or more contributor license agreements. See the NOTICE file
distributed with this work for additional information
regarding copyright ownership. The ASF licenses this file
to you under the Apache License, Version 2.0 (the
"License"); you may not use this file except in compliance
with the License. You may obtain a copy of the License at
http://www.apache.org/licenses/LICENSE-2.0
Unless required by applicable law or agreed to in writing,
software distributed under the License is distributed on an
"AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY
KIND, either express or implied. See the License for the
specific language governing permissions and limitations
under the License.
-->
Thanks for your contribution to [Apache Tika](https://tika.apache.org/)!
Your help is appreciated!
Before opening the pull request, please verify that
* there is an open issue on the [Tika issue
tracker](https://issues.apache.org/jira/projects/TIKA) which describes the
problem or the improvement. We cannot accept pull requests without an issue
because the change wouldn't be listed in the release notes.
* the issue ID (`TIKA-XXXX`)
- is referenced in the title of the pull request
- and placed in front of your commit messages surrounded by square
brackets (`[TIKA-XXXX] Issue or pull request title`)
* commits are squashed into a single one (or few commits for larger changes)
* Tika is successfully built and unit tests pass by running `mvn clean test`
* there should be no conflicts when merging the pull request branch into the
*recent* `main` branch. If there are conflicts, please try to rebase the pull
request branch on top of a freshly pulled `main` branch
* if you add new module that downstream users will depend upon add it to
relevant group in `tika-bom/pom.xml`.
We will be able to faster integrate your pull request if these conditions
are met. If you have any questions how to fix your problem or about using Tika
in general, please sign up for the [Tika mailing
list](http://tika.apache.org/mail-lists.html). Thanks!
> Thread-safety issue in TikaToXMP.getConverterMap()
> --------------------------------------------------
>
> Key: TIKA-4393
> URL: https://issues.apache.org/jira/browse/TIKA-4393
> Project: Tika
> Issue Type: Bug
> Components: tika-app
> Affects Versions: 2.9.3, 3.1.0
> Environment: java 8, fedora 3.9, tika 2.9.3
> Reporter: Ghiles OUAREZKI
> Priority: Minor
>
> h2. Description:
> We execute TikaToXmp conversion in a multithreaded environment where we call
> multiple conversion at the same time. According to new parser contribution
> guide, there is nothing about thread-safety. During our test, a thread-safety
> issue has been found in the getConverterMap() method of the TikaToXMP class
> in the tika-xmp module.
>
> We are currently using the 2.9.3 version. We checked in the latest version
> and we think the behavior is the same.
> h2. Problem:
> The method manipulates the static class variable converterMap, but it is not
> thread-safe. Since there is no synchronization mechanism, multiple threads
> can enter getConverterMap() at the same time and create different instances
> of converterMap, leading to potential race conditions.
> Current code:
> {code:java}
> private static Map<MediaType, Class<? extends ITikaToXMPConverter>>
> converterMap;
> private static Map<MediaType, Class<? extends ITikaToXMPConverter>>
> getConverterMap() {
> if (converterMap == null) {
> converterMap = new HashMap<>();
> initialize();
> }
> return converterMap;
> }
> {code}
> If multiple threads call getConverterMap() simultaneously when converterMap
> is still null, they might create multiple instances of converterMap, which
> can lead to unexpected behavior.
> h2.
> Potential solution:
> To ensure thread safety, we offer a simple patch : to synchronize
> getConverterMap() so that only one thread can initialize converterMap at a
> time. The fix consists of adding the *synchronized* keyword to the method:
> {code:java}
> private static synchronized Map<MediaType, Class<? extends
> ITikaToXMPConverter>> getConverterMap() {
> if (converterMap == null) {
> converterMap = new HashMap<>();
> initialize();
> }
> return converterMap;
> }{code}
>
--
This message was sent by Atlassian Jira
(v8.20.10#820010)
