I suppose your goal was code economy, so maybe you don't care, but: by not adding the code to deal with repeats, you're forcing the resulting release/press pairs to be handled by the toplevel event loop, one undoing the effect of the other.
Visually though it shouldn't be an issue: like I said, I believe both are placed on the queue at once, so for instance it will not happen that the tag flickers. On Tue, Sep 21, 2010 at 10:19:55PM -0700, Wolf Tivy wrote: > Ok so I'm done my little mods, works great. I have attached > a 'patch' so that the rest of you can play with it. > Some possible breakage is that the new view function > doesn't toggle between the two tag sets. Still works for me > though. I find this new interface to be much nicer than the > seperate toggle functions. Thanks for all the help! > > ----- Original Message ----- > From: Wolf Tivy <wti...@my.bcit.ca> > Date: Monday, September 20, 2010 9:44 pm > Subject: [dev] [dwm] tagging interface > To: dev@suckless.org > > > I would like to change the way tag selection works in my dwm. > > The way I think it should work is if you press two (or more) tag > > select keysbefore you release one of them, dwm would select both > > tags. Likewise for tagging windows. I think this would make the > > tagging stuff much more usable and intuitive. > > > > I thought it would be a simple matter of adding another flag and > > testing/setting it appropriately on keyup and keydown events. > > But then I looked at dwm.c and it looks like it's set up to handle > > 'keypress' events where what I want is 'keydown' and 'keyup'. > > > > So does anyone know how to change the mode or something so > > that we can get the paired events instead of just 'keypress'? > > I know this is possible somewhere because that's how SDL does it. > > > > Thanks. > > -Wolf > >
