Hello, On Tue, 4 Aug 2026 at 10:45, Daniel Sahlberg <[email protected]> wrote:
> Den mån 3 aug. 2026 kl 19:02 skrev Pavel Lyalyakin via dev < > [email protected]>: > >> Hello, >> >> INSTALL says that I have to explicitly specify --with-serf when running >> ./configure to enable ra_serf. This doesn't seem to be the case because >> pkg-config is used to automatically detect whether libserf is installed on >> the system. >> >> (I think that the current wording is from the ra_neon era, when >> --with-serf selected ra_serf instead of ra_neon). >> > > I see that the existing text use the word "place" but for all other uses > (except for BDB) we use the word "location" so I would take the opportunity > to change it here. > > I would suggest to add something about "if you don't have pkg-config > installed" (as you already discovered in an earlier mail onlist[1] ). I do > see that we mention pkg-config elsewhere and I assume the same issue occur > for all dependencies if you don't have pkg-config installed so maybe that > is something that could go into section I.C.14? > That pkg-config part can be improved by changing the document's layout and by explicitly stating that pkg-config is used for automatic detection of some of SVN's dependencies (with a list of said dependencies). Adding a note about pkg-config to each dependency's section is somewhat bulky and just duplicates info that can be stated once is a single place (like a hypothetical section 'Build system dependencies', separate from the other dependencies). The thing is that the INSTALL document needs a major rework (I think that everyone can agree with this). Right now I'm going through the document and attempting to fix the most obvious issues where a small fix would be a real improvement over the current version. The pkg-config issue is more of a structural one, IMHO, so I'm putting it off until the smaller issues are fixed. I hope I should be able to suggest a better INSTALL layout a bit later, which by itself might resolve many of the issues with the document. > If you want to add the pkg-config related note under the Serf headline, > maybe something like: > > "If you don't use pkg-config and serf is installed in a non-standard > location, you should use" > Yep, this reads better, but I changed "..., you should use" to "..., then use:" for consistency. > Whichever way you choose, you have my +1 to edit INSTALL as you see fit, > either this patch or a variation thereof. > An updated variant committed in r1936877. Thanks for the review! > Thanks, > Daniel > > > [1] https://lists.apache.org/thread/7f51kjmlxqls7nql8q5v0l22f0m5c372 > > >> >> Log message: >> >> * INSTALL >> (I.C.7): clarify that libserf is automatically detected by pkg-config >> >> Patch by: Pavel Lyalyakin <[email protected]> >> >> -- >> With best regards, >> Pavel Lyalyakin >> VisualSVN Team >> > -- With best regards, Pavel Lyalyakin VisualSVN Team
