On 29. 9. 25 11:36, Đoàn Trần Công Danh wrote:
On 2025-09-28 14:12:51+0200, Branko Čibej<[email protected]> wrote:
On 28. 9. 25 12:17, Đoàn Trần Công Danh wrote:
[[[
Support KDE 6, it's released in Feb 2024, which is 19 months ago.
* build/ac-macros/compiler.m4
Switch to C++17, since Qt6 requires C++17
* build/ac-macros/kwallet.m4
Check for KDE 6's libraries
* subversion/libsvn_auth_kwallet/kwallet.cpp
Update preprocessor for KDE 6
]]]
---
diff --git a/build/ac-macros/compiler.m4 b/build/ac-macros/compiler.m4
--- a/build/ac-macros/compiler.m4
+++ b/build/ac-macros/compiler.m4
@@ -102,7 +102,7 @@ AC_DEFUN([SVN_CXX_MODE_SETUP],
if test "$GXX" = "yes"; then
dnl Find flags to force C++98 mode
dnl g++ and clang++
- SVN_CXXFLAGS_ADD_IFELSE([-std=c++11])
+ SVN_CXXFLAGS_ADD_IFELSE([-std=c++17])
fi
Thanks for the patch!
The C++ version flag doesn't match the version in the comment; yes, that was
true before, this is an ideal time to fix the comment.
Did you, by any chance, build JavaHL and svnxx after this change? The C++
compiler version affects more than just KWallet.
Yes, JavaHL and svnxx works with C++17.
Also, I see that trunk has been changed to allow build with c++23,
c++20, c++17, preferably, on that order.
Ah! That sort of makes sense, yes.
The patch was made on top on 1.14.5. It can be applied on top of trunk
if we drop the patch on build/ac-macros/compiler.m4
Do please base the patch on trunk. Our process is to make changes on
trunk first, then backport them to stable branches.
-- Brane
