On 28. 9. 25 12:17, Đoàn Trần Công Danh wrote:
[[[
Support KDE 6, it's released in Feb 2024, which is 19 months ago.

* build/ac-macros/compiler.m4
   Switch to C++17, since Qt6 requires C++17
* build/ac-macros/kwallet.m4
   Check for KDE 6's libraries
* subversion/libsvn_auth_kwallet/kwallet.cpp
   Update preprocessor for KDE 6
]]]

---

diff --git a/build/ac-macros/compiler.m4 b/build/ac-macros/compiler.m4
--- a/build/ac-macros/compiler.m4
+++ b/build/ac-macros/compiler.m4
@@ -102,7 +102,7 @@ AC_DEFUN([SVN_CXX_MODE_SETUP],
    if test "$GXX" = "yes"; then
      dnl Find flags to force C++98 mode
                    dnl g++ and clang++
-    SVN_CXXFLAGS_ADD_IFELSE([-std=c++11])
+    SVN_CXXFLAGS_ADD_IFELSE([-std=c++17])
    fi


Thanks for the patch!

The C++ version flag doesn't match the version in the comment; yes, that was true before, this is an ideal time to fix the comment.

Did you, by any chance, build JavaHL and svnxx after this change? The C++ compiler version affects more than just KWallet.

(That said, if possible, we should probably upgrade to C++20 anyway.)


-- Brane

Reply via email to