Hi, I noticed that there are two different functions in different libraries (libsvn_subr and libsvn_client) which are doing almost the same thing. But, one in subr is permanently deprecated.
Fine, it was moved to the client. But the thing is the old one (which has been deprecated) is still used in svnadmin and svnsync programs since they can't link with libsvn_client. And not only that, but for some reason they rely on a private util svn_opt__args_to_target_array. It reveals two problems at the same time. First is deprecated api usage in our cmdline which is bad. The hack with svn_opt__args_to_target_array seems to hide this even more. Also I don't see any reason to implement this function in svnclient. It doesn't make sense to me. Should we move the common one to the subr and use it then? Please note that those functions are a little bit different in behavior. The svn_opt's one doesn't implement some functionality that svn_client's does. -- Timofei Zhakov
