Den mån 19 juni 2023 kl 00:29 skrev Nathan Hartman <hartman.nat...@gmail.com >:
> On Sat, Jun 17, 2023 at 7:33 AM Daniel Sahlberg < > daniel.l.sahlb...@gmail.com> wrote: > >> Den fre 16 juni 2023 kl 09:49 skrev Osipov, Michael (SMD IT IN) via users >> <us...@subversion.apache.org>: >> >>> Scratch that. My thread from five years ago is still valid: >>> https://lists.apache.org/thread/lonftwtj2kmnjf5mlp91jyxz9xlsgv3d >>> >>> The issue sill persists. The doc improvement from Daniel Shahaf haven't >>> been implemented yet. >>> >> >> Moving the discussion to dev@: >> >> Do we want to implement the suggested doc improvement? I started testing >> each of the commands and the @ trick is required on almost all except for >> svn checkout so it will be a lot of changed text. Does it make sense or >> will it only be a cause of confusion? >> > > > I think it's a good idea as it will help to make the documentation more > clear and complete. > First try committed as r1910826 (and ..33). I'm not sure if it makes the documentation more clear or if it just adds word that doesn't make any sense. I was considering changing URL[@REV] to URL[@[REV]] since the revision is optional. Otherwise we might mention this explicitly. Check the svn book in peg revisions: https://svnbook.red-bean.com/en/1.7/svn.advanced.pegrevs.html I added the explanation as a separate text to allow for some re-use but the >> argument has many different names (PATH, WCPATH, URL ...) so it is repeated >> a few times, maybe it can be reworded to leave out the argument name? >> > > > Hmmm, it looks like we're not entirely consistent: In my mind, PATH could > be a working copy path or a repository path, while WCPATH must be a working > copy path. But, looking at the help strings for, e.g., 'svn add', it calls > for a PATH; I would expect to see WCPATH... (Is there a way to schedule a > path already in the repository for addition?) > There is some explaination in the code: [[[ * In most of the help text "PATH" is used where a working copy path is * required, "URL" where a repository URL is required and "TARGET" when * either a path or a url can be used. Hmm, should this be part of the * help text? ]]] But that doesn't explain WCPATH. I agree that it can sometimes be confusing and it would probably be good to go through the text again. Kind regards, Daniel Sahlberg
