On Tue, Nov 12, 2019 at 10:39 AM Julian Foad <julianf...@apache.org> wrote:
> Nathan Hartman wrote: > > What about my "SWIG version 2.0.0 and later" singular / plural question > > and mix of treating it as singular in some places and plural in others? > > "SWIG versions 2 and later are ..." > "SWIG version 2 or later is ..." > > If there are no concerns about the substance of the patch, I suggest a > good course of action is to commit it ASAP, then just make your edits in > follow-up commits, and optionally mention in email that you did so. > Even when some of the language is a bit unclear, most of this sort of > thing doesn't need pre-commit review. I agree. Yasuhito, if possible could you please commit your patch? Then, I will work on the description in the INSTALL file and I'll incorporate the good input from Daniel, Julian, and Brane... :-) Thanks! Nathan
