On Thu, Oct 10, 2019 at 1:48 PM Daniel Shahaf <d...@daniel.shahaf.name> wrote:
> Nathan Hartman wrote on Thu, 10 Oct 2019 17:36 +00:00: > > On Thu, Oct 10, 2019 at 1:15 PM Daniel Shahaf <d...@daniel.shahaf.name> > wrote: > > > > > > Nathan Hartman wrote on Thu, Oct 10, 2019 at 10:24:28 -0400: > > > > * Documentation: > > > > > > > > - SVN-3914 - INSTALL: document how to compile with libmagic on > > > > Windows. > > > > https://issues.apache.org/jira/browse/SVN-3914?issueNumber=3914 > > > > > > This is a subtask of the next one, isn't it? > > > > I separated them because one is documentation, the other is Python > > programming. I tried to keep things organized by skill set. Also SVN-3914 > > didn't actually include updating the scripts (unless I missed something). > > > > Should these be re-merged into one item, as you had it before? > > That depends. _Do_ the Windows build scripts support libmagic? > Good question. I've never built SVN on Windows, only Unix, so I don't actually know. I can look at the build scripts but if someone knows the answer to this please chime in!! More below > We can include the github link but there was a whole discussion here > > about how pull requests were sitting there untouched, and there was no > > clean way to accept them and have them marked as such. Has that been > > fixed? If not, I'd rather avoid the confusion that would cause. Let me > > know... > > Sure, there's no point in recommending a patch submission channel that's > not easy for us to work with. However, there's a third option: post the > github link but ask patches to be emailed. (We should probably just add > the link to HACKING, though, in that case; it's not specific to this > event.) We could do that and monitor github during the event in case some participants don't notice the request to mail patches. But we should eventually figure out a better solution for that submission channel.
