Julian Foad <julianf...@apache.org> writes:

> Philip Martin wrote:
>> cached_data.c:parse_raw_window() where the svndiff version is hard-coded
>> to 1 in the call to svn_txdelta_read_svndiff_window.  Changing that to 2
>> allows the regression test to pass, the question is where should the
>> correct value be obtained?
>
> The simple answer appears to be 'rs->ver' (where 'rs' needs to be
> passed in via the function's baton).

It's not that simple.  When we cache the data rs->ver is set to 1 by
init_rep_state().  When we retrieve the data rs->ver is set to -1 by
create_rep_state().  I don't know why these functions initialize rs
differently.  Neither appears to be the value we want.

-- 
Philip

Reply via email to