Troy Curtis Jr wrote on Thu, 30 Nov 2017 02:20 +0000: > On Wed, Nov 29, 2017, 10:08 AM Daniel Shahaf <d...@daniel.shahaf.name> wrote: > > troycurti...@apache.org wrote on Wed, 29 Nov 2017 03:50 +0000: > > > * Makefile.in > > > (EXTRACLEAN_SWIG_PY): Change SWIG_PY_SRC_DIR to SWIG_PY_DIR to > > correctly > > > reference generated files in out-of-source builds. > > > > Shouldn't this go to trunk? > > > > Probably, but eventually I hope the whole branch will make it to trunk. :)
Certainly. :-) When you think the branch (or parts of it) are ready, just start a dev@ thread identifying them. > But if you think it should go ahead and get put to trunk I'd be happy to do > so, you may be worried that I'm dragging this swig-py3 branch thing out :P I just think that, as a matter of best practices, small commits that are independent of the branch should go to trunk directly (& can be cherry- picked back to the feature branch). You shouldn't read any "slow progress" concern into it, no more than you should take offence at me wearing a seat belt while you're driving. > > While reviewing this I noticed that > > subversion/bindings/swig/proxy/svn_*.swg > > are created in the source dir rather than in the build dir. I suspect > > that might be a bug but I'm not familiar enough with these swig details. > > > > > Since I've been working in this area, I'll take a look and add a fix as > necessary. Thanks! Cheers, Daniel > Thanks! > Troy
