On 17 August 2016 at 01:47, Daniel Shahaf <d...@daniel.shahaf.name> wrote: > i...@apache.org wrote on Sat, Aug 13, 2016 at 13:18:57 -0000: >> Author: ivan >> Date: Sat Aug 13 13:18:57 2016 >> New Revision: 1756266 >> >> URL: http://svn.apache.org/viewvc?rev=1756266&view=rev >> Log: >> FSFS: Write the sha1->rep mapping in transaction *after* we successfully >> written node revision to disk. Otherwise may get orphaned sha1->rep mapping >> entry if an error occurs when writing p2l index entry. > > Should this be backported? I.e., what are the consequences of an > orphaned sha1->rep entry? > > If it's possible for an orphaned entry to be added to rep-cache.db > [e.g., by reopening and committing the transaction], then I think this > should be backported. [since that constitutes latent corruption] > Nominated to 1.9.x branch. Note that standard Subversion tools should not be affected because it aborts transaction on any error and this clears on sha1->rep entries for transaction.
-- Ivan Zhakov
