Belated review: i...@apache.org wrote on Mon, Aug 08, 2016 at 10:32:29 -0000: > +/** Return in @a *checksum the checksum of type @a kind of @a stream. > + *
Have the docstring state whether STREAM is read from, written to, or both? (I know the answer; I am just proposing the docstring should state it explicitly.) > + * Stream will be closed before this function returns (regardless of > + * the result, or any possible error). > + * s/Stream/@a stream/ Or: s/Stream/The stream/ > + * Use @a scratch_pool for temporary allocations and @a result_pool > + * to allocate @a *checksum. > + * > + * @since New in 1.10. > + */ > +svn_error_t * > +svn_stream_checksum(svn_checksum_t **checksum, This interface seems very similar to svn_stream_checksummed(), both in name and in functionality. Cheers, Daniel > + svn_stream_t *stream, > + svn_checksum_kind_t kind, > + apr_pool_t *result_pool, > + apr_pool_t *scratch_pool); > +
