oclei...@tigris.org wrote on Thu, Jul 04, 2013 at 13:43:08 -0700:
> ------- Additional comments from oclei...@tigris.org Thu Jul 4 13:43:08
> -0700 2013 -------
> Thanks for [cmpilato's] feedback.
>
> I was thinking that in modern SVN the author and commit date would always
> exist
> so that was a way to approach the check.
>
> But the core issue is that the 4389-filered.dump file contains revision
> properties but when it is imported they are not and no warning is given.
>
> The svnadmin load and svnrdump load commands do make some consistency checks
> (like verifiying the checksums) so it seemed to me that this is another
> variation to add.
>
+1.
>From notes/dump-load-format.txt:
Revision-number: <N>
Prop-content-length: <P>
Content-length: <L>
... <P> gives the length in bytes of the following property section.
<L> gives the body length of the entire Revision record. These two
numbers will be *identical* for a Revision record; ...
(emphasis in the original)
So it would be useful for the parser to set both headers when parsing
a Revision-number headers --- and to warn if one of them is absent, or
if they are set to different values.
Daniel
> I'd be happy with the check you suggest where if properties exist and the
> Prop-content-length header is missing to fail the import.
