C. Michael Pilato wrote on Mon, Jul 01, 2013 at 14:13:50 -0400: > On 07/01/2013 02:01 PM, Daniel Shahaf wrote: > > C. Michael Pilato wrote on Mon, Jul 01, 2013 at 13:23:59 -0400: > >> On 07/01/2013 11:54 AM, Daniel Shahaf wrote: > >>> SVN_RA_CAPABILITY_EPHEMERAL_TXNPROPS seems to be queried only by the > >>> libsvn_ra_serf and libsvn_ra_svn. Is there a reason not to either: > >>> > >>> - Make ra_local set those properties too > >>> or > >>> - Move the logic querying that capability (and when available setting > >>> svn:txn-* revprops) to ra_loader.c > >>> > >>> ? > >> > >> There's no reason to query the capability in ra_local (tautology?). But > >> yeah, I think it makes sense for ra_local to set the properties, too. > > > > Done that in r1498608. > > I saw the "user-agent" change go through. What about "compat-version"? Did > you intentionally omit that one?
No; svn:txn-client-compat-version was already being set over ra_local. >From the r1498608 diff: @@ -765,6 +778,8 @@ svn_ra_local__get_commit_editor(svn_ra_s svn_string_create(sess->username, pool)); svn_hash_sets(revprop_table, SVN_PROP_TXN_CLIENT_COMPAT_VERSION, svn_string_create(SVN_VER_NUMBER, pool)); + svn_hash_sets(revprop_table, SVN_PROP_TXN_USER_AGENT, + svn_string_create(sess->useragent, pool));