Stefan Sperling wrote on Mon, Feb 11, 2013 at 12:36:29 +0100: > On Mon, Feb 11, 2013 at 09:38:05AM +0000, Philip Martin wrote: > > Stefan Sperling <s...@elego.de> writes: > > >> +svn_error_t * > > >> +svn_subst_build_keywords3(apr_hash_t **kw, > > >> + const char *keywords_string, > > >> + const char *rev, > > >> + const char *url, > > >> + const char *repos, > > >> + apr_time_t date, > > >> + const char *author, > > >> + apr_pool_t *pool); > > >> + > > > > Our private API uses a double underscore svn_subst__build_keywords3 > > however this is replacing a public API svn_subst_build_keywords2 > > declared in include/svn_subst.h. > > > > Is the intention to deprecate the entire svn_subst_build_keywords public > > API? Or is svn_subst_build_keywords3 intended to be the new public API? > > I believe I can explain this, given the history of this patch. > > This was a patch to the FreeBSD port, and I suppose they made the new > APIs they added in that patch private because it wasn't part of the > official public API. So, yes, this API should be public now that the > intention is to add it to the upstream code base.
Yes, that's correct. They used to declare the API in subversion/include/, but the declaration has been moved to subversion/include/private/ since it wasn't part of our (upstream's) public API: http://www.freebsd.org/cgi/query-pr.cgi?pr=165311
