Julian Foad wrote on Mon, Mar 11, 2013 at 11:33:09 +0000: > Daniel Shahaf wrote: > > [...] > > FWIW, it would have been nice to see a diff of build-outputs.mk as > > well... > > Hi Daniel. Here's the change to build-outputs.mk as seen on my Ubuntu 12.04 > system: >
Thanks Julian! > [[[ > $ diff -U1 install-*.mk This says we treat mod_dontdothat as though it was a core module (subversion/mod_dontdothat): it is included in 'make apache-mod' (part of 'make'), excluded from 'make tools' (part of 'make' too, as of 1.8), included in 'make install-mods-shared' (and there's no install-tools-mods-shared target, IIRC). I think that's wrong. Those makefile targets are for core modules and this one is only a tools/ module at this point. Specifically, including mod_dontdothat in 'make install' (rather than 'make install-tools') may create false user expectations: users who don't run "make install-tools" except only core stuff to be installed, but mod_dontdothat is tools/ and not core. Cheers, Daniel
