Andreas Stieger wrote:

> The installation of mod_dontdothat was moved to make install-tools,
> however the trunk code tries to install with libtool which fails with
> the message: cannot install mod_dontdothat.la to a directory not ending
> in [...]/lib/apache2/modules
> 
> The attached patch fixes this. This was mentioned earlier here:
> http://mail-archives.apache.org/mod_mbox/subversion-dev/201302.mbox/%3c87ip5yhlrd....@ntlworld.com%3E
> 
> This can be seen working with an rpm package of the nightly trunk
> tarballs here:
> https://build.opensuse.org/package/show?package=subversion&project=home%3AAndreasStieger%3Asvn18
> 
> [[[
> * build.conf
>   (mod_dontdothat): install as apache module
> ]]]

With this patch, I confirm that my install (from an out-of-source-tree build) 
now completes without throwing an error.  It now installs mod_dontdothat during 
"make install-mods-shared" instead of during "make install-tools".

However, I don't know if that's what we really want.  If something is under 
"tools", that suggests to me that it should be installed by "install-tools" and 
perhaps not by "install-mods-shared"... but we have to do something.  I have no 
particular objection, as I'm sure package managers can work around it whatever 
way they wish.

What do others think?

- Julian

Reply via email to