Julian Foad wrote on Wed, Oct 31, 2012 at 17:14:02 +0000: > Prabhu Gnana Sundar <prabh...@collab.net> wrote: > > +notify_verification_error(svn_revnum_t rev, svn_error_t *err, > > + svn_repos_notify_func_t notify_func, > > + void *notify_baton, apr_pool_t *pool)
Another thing I noticed is that this function re-allocates a notification object every time it's called. I'm not sure, but it might be a good idea to rework it to allocate a single notification object per call to svn_repos_verify_fs3() (as the "Verified revision %ld." notification already does)?