On Apr 25, 2012 7:40 AM, "Daniel Shahaf" <danie...@elego.de> wrote: > > Bert Huijben wrote on Wed, Apr 25, 2012 at 12:52:07 +0200: > > > > > > > -----Original Message----- > > > From: Daniel Shahaf [mailto:danie...@elego.de] > > > Sent: woensdag 25 april 2012 11:46 > > > To: Greg Stein > > > Cc: Hyrum K Wright; dev@subversion.apache.org > > > Subject: Re: svn commit: r1329609 - in /subversion/trunk/subversion: > > > include/svn_error.h libsvn_fs/fs-loader.c > > > > > > > if (!(expr)) { > > > svn_error_t *e1 = (err), *e2 = svn_error__malfunction(); > > > return (e1 ? svn_error_compose_create(e2, e1) : e2); > > > } > > > > svn_error_compose_create() has no problems with NULL arguments. > > > > I know, I think Greg's concern was calling it too often (as opposed to > calling it with NULL)
Yup. Especially after we just got done talking about how these remain in production code. Cheers, -g
