Stefan Sperling wrote on Thu, Aug 18, 2011 at 18:23:24 +0200: > On Thu, Aug 18, 2011 at 07:16:40PM +0300, Daniel Shahaf wrote: > > ne...@apache.org wrote on Thu, Aug 18, 2011 at 14:24:12 -0000: > > > Author: neels > > > Date: Thu Aug 18 14:24:12 2011 > > > New Revision: 1159240 > > > > > > URL: http://svn.apache.org/viewvc?rev=1159240&view=rev > > > Log: > > > On 'hold' branch: Block commits for files that have the 'svn:hold' prop. > > > > > > * subversion/include/svn_props.h > > > (SVN_PROP_HOLD): New #define. > > > > > > * subversion/libsvn_client/commit_util.c > > > (harvest_committables): > > > Check for 'svn:hold' prop and exclude files from committables if > > > found. > > > > > > * subversion/include/private/svn_wc_private.h > > > (svn_wc__node_get_commit_status), > > > * subversion/libsvn_wc/node.c > > > (svn_wc__node_get_commit_status): > > > Also return parameter HAD_PROPS for slight optimization in > > > harvest_committables(). > > > > Neels, > > > > I went ahead and put together a regression test for this. It XPASS()es > > when I use changelists instead of svn:hold. > > As far as I know, Neels would like to allow this 'hold' status to > be transmittable to other working copies via commit/update. > So a changelist is not the same thing. >
I used a changelist for debugging purposes during test development: - svn propset svn:hold A/D/G/pi - svn commit A/D/G - XFAIL + svn cl foo A/D/G/rho + svn commit A/D/G --cl foo + XPASS > This is why this is on a branch -- the implementation is WIP and > there is more to come. > > But Neels can probably explain better.
