On Thu, Jun 3, 2010 at 12:53, Greg Stein <[email protected]> wrote: > On Tue, Jun 1, 2010 at 08:40, Philip Martin <[email protected]> > wrote: >> "Hyrum K. Wright" <[email protected]> writes: >> >>>> scratch_pool); >>>> - const char *properties = svn_sqlite__column_text(stmt, 6, >>>> scratch_pool); >>>> + apr_size_t props_size; >>>> + const char *properties = svn_sqlite__column_blob(stmt, 6, >>>> &props_size, >>>> + scratch_pool); >>>> >>> >>> Should we be using svn_sqlite__column_properties() here (and extending >>> _bindf() so that it knows about properties)? I understand we're just doing >>> a straight copy, so we don't necessarily need to parse and unparse the >>> properties, but if this is the case, perhaps a comment in the code would be >>> useful. >> > > It is still nice to have a comment that the properties are being > passed as an unserialized blob. That code will live for another couple > months (probably), and who knows how many times it will be read (or > copied or referred to as an example) in the meantime.
(euh... that was in response to Philip's "Perhaps..." comment)
