"Hyrum K. Wright" <hyrum_wri...@mail.utexas.edu> writes:

>>  scratch_pool);
>> -      const char *properties = svn_sqlite__column_text(stmt, 6,
>> scratch_pool);
>> +      apr_size_t props_size;
>> +      const char *properties = svn_sqlite__column_blob(stmt, 6,
>> &props_size,
>> +                                                       scratch_pool);
>>
>
> Should we be using svn_sqlite__column_properties() here (and extending
> _bindf() so that it knows about properties)?  I understand we're just doing
> a straight copy, so we don't necessarily need to parse and unparse the
> properties, but if this is the case, perhaps a comment in the code would be
> useful.

Perhaps. It's all temporary and will disappear when we centralise.

-- 
Philip

Reply via email to