On Fri, Apr 02, 2010 at 11:06:32AM +0200, Daniel Näslund wrote:
> gstein pointed out that I should use SVN_IS_VALID_REVNUM(). Fixed!

> @@ -290,6 +290,16 @@ main(int argc, const char *argv[])
>        return EXIT_FAILURE;
>      }
>  
> +  if (SVN_IS_VALID_REVNUM(res->min_rev))

Doesn't this reverse the meaning of what you had before?

Maybe use:

     if (! SVN_IS_VALID_REVNUM(res->min_rev))

or use

     if (SVN_IS_INVALID_REVNUM(res->min_rev))

if there is such a macro.

> +    {
> +      /* Local uncommited modifications, no revision info was found. */
> +      SVN_INT_ERR(svn_cmdline_printf(pool, _("Uncommitted local addition "
> +                                             "copy, or move%s"),
> +                                             no_newline ? "" : "\n"));
> +      svn_pool_destroy(pool);
> +      return EXIT_SUCCESS;
> +    }
> +
>    /* Build compact '123[:456]M?S?' string. */
>    SVN_INT_ERR(svn_cmdline_printf(pool, "%ld", res->min_rev));
>    if (res->min_rev != res->max_rev)

Reply via email to