Bert Huijben wrote: > Julian Foad wrote: > > On Mon, 2010-03-08 at 21:34 +0000, rhuij...@apache.org wrote: > > > (install_added_props): Remove call to > > svn_wc__db_base_set_dav_cache() > > > as the only caller, svn_wc_add_repos_file4() should never change > > > BASE_NODE information. (The information that was stored before this > > > patch is from the copy from origin, which is unrelated to the > > > BASE_NODE) > > > > Please could you update the function's doc string. It says "BASE_PROPS > > can contain entryprops and wcprops as well", implying that it does > > something with both kinds, and now it doesn't. > > BASE_PROPS refers to the 'unmodified properties', to be stored in > WORKING_NODE (See: @BASE), not to the properties of the BASE_NODE/checked out > state (@ORIGINAL). > This comment was written before the definition changed with WC-NG.
That function is in a half-way state of massive transition and its doc string was completely out of kilter. I've verbosely augmented it in r920868. - Julian
