On Mon, 2010-03-08 at 21:34 +0000, rhuij...@apache.org wrote: > Author: rhuijben > Date: Mon Mar 8 21:34:38 2010 > New Revision: 920526 > > URL: http://svn.apache.org/viewvc?rev=920526&view=rev > Log: > * subversion/libsvn_wc/update_editor.c > (install_added_props): Remove call to svn_wc__db_base_set_dav_cache() > as the only caller, svn_wc_add_repos_file4() should never change > BASE_NODE information. (The information that was stored before this > patch is from the copy from origin, which is unrelated to the > BASE_NODE)
Please could you update the function's doc string. It says "BASE_PROPS can contain entryprops and wcprops as well", implying that it does something with both kinds, and now it doesn't. - Julian > Modified: > subversion/trunk/subversion/libsvn_wc/update_editor.c > > Modified: subversion/trunk/subversion/libsvn_wc/update_editor.c > URL: > http://svn.apache.org/viewvc/subversion/trunk/subversion/libsvn_wc/update_editor.c?rev=920526&r1=920525&r2=920526&view=diff > ============================================================================== > --- subversion/trunk/subversion/libsvn_wc/update_editor.c (original) > +++ subversion/trunk/subversion/libsvn_wc/update_editor.c Mon Mar 8 21:34:38 > 2010 > @@ -6023,9 +6023,7 @@ > SVN_ERR(accumulate_last_change(last_change, NULL, db, local_abspath, > entry_props, pool, pool)); > > - return svn_error_return(svn_wc__db_base_set_dav_cache(db, local_abspath, > - prop_hash_from_array(wc_props, pool), > - pool)); > + return SVN_NO_ERROR; > } > > /* Append, to LOG_ACCUM, log commands to update the entry for LOCAL_ABSPATH > >
