rzo1 commented on PR #1935: URL: https://github.com/apache/stormcrawler/pull/1935#issuecomment-4690200421
> +1 from my side. Good coverage, including the edge cases for partial auth, out-of-range ports, and credentials with reserved characters. Fail-fast on invalid metadata is the right call. > > Minor note for a follow-up: `getConfiguredProxy` in `MultiProxyManager` does a linear scan per metadata-override request. With large proxy lists a `HashMap` keyed on normalized `protocol+host+port` in `configure()` would avoid the per-request work. Not a blocker here — @rzo1 worth an issue? We can fix enhance that later, yes. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
