preko-p commented on PR #1935: URL: https://github.com/apache/stormcrawler/pull/1935#issuecomment-4657956736
Thanks for the careful review. I pushed a small follow-up for both points: - replaced the `toString()` comparison in `getConfiguredProxy()` with a normalized semantic proxy comparison, so component-key metadata can match a configured proxy even when the configured protocol casing differs - added a regression test for that path under `LEAST_USED` so the configured proxy instance gets the usage increment - consolidated the shared `1..65535` port bound check while keeping metadata string parsing/error handling in `ProxyMetadata` Local verification: ```bash git diff --check /tmp/apache-maven-3.9.9/bin/mvn -pl core -Dtest=MultiProxyManagerTest,SingleProxyManagerTest test ``` The focused Maven run passed: 30 tests, 0 failures/errors. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
