jnioche commented on code in PR #1929:
URL: https://github.com/apache/stormcrawler/pull/1929#discussion_r3360952721
##########
core/src/main/java/org/apache/stormcrawler/util/CookieConverter.java:
##########
@@ -110,17 +108,17 @@ public static List<Cookie> getCookies(String[]
cookiesStrings, URL targetURL) {
// check expiration
if (expires != null) {
try {
- Date expirationDate = DATE_FORMAT.parse(expires);
- cookie.setExpiryDate(expirationDate);
-
- // check that it hasn't expired?
- if (cookie.isExpired(new Date())) {
- continue;
+ Date expirationDate =
org.apache.http.client.utils.DateUtils.parseDate(expires);
Review Comment:
we have dependencies on o.a.httpclient in various places, it is acceptable
to have it here too
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
