dpol1 opened a new pull request, #1929:
URL: https://github.com/apache/stormcrawler/pull/1929
`SimpleDateFormat` and shared `Matcher` instances are not thread-safe.
In a multi-threaded Storm topology this can cause silent data corruption
or incorrect results under concurrent load.
- `RefreshTag`: replace static shared `Matcher` with a `Pattern` constant
and a per-call `Matcher` instance
- `FileResponse`: replace `SimpleDateFormat` with `DateTimeFormatter`
(also use try-with-resources for `FileInputStream` in the same class)
- `CookieConverter`: replace `SimpleDateFormat` with
`DateUtils.parseDate()`;
also fix a duplicate `setExpiryDate()` call and add a null guard on the
parsed date
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
