> On March 28, 2018, 11:02 a.m., daniel voros wrote:
> > Hey Anna,
> >
> > I've experimented with running the gradle build in a clean dockerized
> > environment and found some minor issues:
> > 1) All dependencies are downloaded from jcenter, despite having central
> > repository defined in build.gradle. This might be a result of my current
> > setup, could you please confirm?
> > 2) Deprecation warnings for '<<' task doLast syntax ("Deprecation warning:
> > The Task.leftShift(Closure) method has been deprecated...")
> > 3) SqoopVersion.java generation happens during task definition and not in
> > action (missing doLast?).
> > 4) `relnotes` task fails if version is SNAPSHOT with: "A problem occurred
> > starting process 'command 'cd''".
> > 5) The `release` task prints the path of tar and rat report but they're
> > incorrect. (I've specified version on the command line with
> > "-Pversion=1.5.0")
> > 6) `ant releaseaudit` now lists gradle files as errors
> >
> > I've corrected 2,3,4,5,6 in this commit:
> > https://github.com/dvoros/sqoop/commit/47e361829b1004bdedd6f5c223332e3fb8b85696
> >
> > What's the reasoning behind using Gradle 3.5.1? Shouldn't we use 4.x? (I've
> > successfully executed a simple build with 4.6)
> >
> > Regards,
> > Daniel
Hi Daniel,
Thanks for testing and the suggestions, I've incorporated your feedback!
Wrt gradle 3.5.1: for myself and some of the people testing this on their local
machine tests weren't running with gradle 4.x+ and the fix wasn't trivial, so
we decided to nail it down to 3.5 and increase it later, as it will probably
result in code change as well.
#1 it uses jcenter for me as well by default, it might be because jcenter
became the new default for gradle, as far as I can tell for the following
reasons:
https://blog.bintray.com/2015/02/09/android-studio-migration-from-maven-central-to-jcenter/,
though tbh this isn't the expected behaviour - does everyone else experience
this also?
#2 Oddly enough it behaves slightly differently for me, but not as
significantly as --tests and test.single so I changed them all
#3 I've added doLast, but it doesn't change the order, not sure if it's worth
further investigation.
#5 I missed this, I will correct it, thanks!
Thanks,
Anna
- Anna
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/66067/#review200102
-----------------------------------------------------------
On April 13, 2018, 9:06 a.m., Anna Szonyi wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/66067/
> -----------------------------------------------------------
>
> (Updated April 13, 2018, 9:06 a.m.)
>
>
> Review request for Sqoop.
>
>
> Bugs: Sqoop-3052
> https://issues.apache.org/jira/browse/Sqoop-3052
>
>
> Repository: sqoop-trunk
>
>
> Description
> -------
>
> SQOOP-3052: Introduce gradle based build for Sqoop to make it more developer
> friendly / open
>
>
> Diffs
> -----
>
> .gitignore 68cbe28731e613607c208824443d1edf256d9c8a
> COMPILING.txt 3b82250488256871352056e9061ad08fabbd7fc5
> build.gradle PRE-CREATION
> config/checkstyle/checkstyle-java-header.txt PRE-CREATION
> config/checkstyle/checkstyle-noframes.xsl PRE-CREATION
> config/checkstyle/checkstyle.xml PRE-CREATION
> gradle.properties PRE-CREATION
> gradle/customUnixStartScript.txt PRE-CREATION
> gradle/customWindowsStartScript.txt PRE-CREATION
> gradle/sqoop-package.gradle PRE-CREATION
> gradle/sqoop-version-gen.gradle PRE-CREATION
> gradle/wrapper/gradle-wrapper.jar PRE-CREATION
> gradle/wrapper/gradle-wrapper.properties PRE-CREATION
> gradlew PRE-CREATION
> gradlew.bat PRE-CREATION
> settings.gradle PRE-CREATION
> src/scripts/rat-violations.sh 1cfbc1502b24dd1b8b7e7ce21f0b5d1880c06556
>
>
> Diff: https://reviews.apache.org/r/66067/diff/7/
>
>
> Testing
> -------
>
> ran all new tasks, except for internal maven publishing
>
> Notes:
> - To try it out you can call ./gradlew tasks --all to see all the tasks and
> compare them to current tasks/artifacts.
> - Replaced cobertura with jacoco, as it's easier/cleaner to configure, easier
> to combine all test results into a single report.
> - Generated pom.xml now has correct dependencies/versions
> - Script generation is currently hardcoded and not based on sqoop help, as
> previously - though added the possiblity of hooking it in later
>
>
> Thanks,
>
> Anna Szonyi
>
>
