----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/66067/#review199930 -----------------------------------------------------------
Hi Anna, I did some deeper testing with your change and found that the number of run 3rd party test cases in case of ant and gradle are different: 782 test cases run with ant but only 595 with gradle. I didn't check all the details but for example with ant 71 test cases runs in SQLServerDatatypeImportSequenceFileTest test class but 0 with gradle. Could you please check this? I also have some minor comments again. Otherwise your change looks very good in general, huge thanks for preparing this patch! Many thanks, Bogi COMPILING.txt Lines 332-341 (patched) <https://reviews.apache.org/r/66067/#comment280437> Could you please separate these parts a bit more consistently? Now the title of this section is Cobertura however with gradle Jacoco would be used. Also, could you please mention here where the reports are generated? build.gradle Lines 143 (patched) <https://reviews.apache.org/r/66067/#comment280435> I might miss something but is this comment needed here? - Boglarka Egyed On March 23, 2018, 10:28 a.m., Anna Szonyi wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/66067/ > ----------------------------------------------------------- > > (Updated March 23, 2018, 10:28 a.m.) > > > Review request for Sqoop. > > > Bugs: Sqoop-3052 > https://issues.apache.org/jira/browse/Sqoop-3052 > > > Repository: sqoop-trunk > > > Description > ------- > > SQOOP-3052: Introduce gradle based build for Sqoop to make it more developer > friendly / open > > > Diffs > ----- > > .gitignore 68cbe28 > COMPILING.txt 3b82250 > build.gradle PRE-CREATION > buildSrc/customUnixStartScript.txt PRE-CREATION > buildSrc/customWindowsStartScript.txt PRE-CREATION > buildSrc/sqoop-package.gradle PRE-CREATION > buildSrc/sqoop-version-gen.gradle PRE-CREATION > config/checkstyle/checkstyle-java-header.txt PRE-CREATION > config/checkstyle/checkstyle-noframes.xsl PRE-CREATION > config/checkstyle/checkstyle.xml PRE-CREATION > gradle.properties PRE-CREATION > gradle/wrapper/gradle-wrapper.jar PRE-CREATION > gradle/wrapper/gradle-wrapper.properties PRE-CREATION > gradlew PRE-CREATION > gradlew.bat PRE-CREATION > settings.gradle PRE-CREATION > > > Diff: https://reviews.apache.org/r/66067/diff/6/ > > > Testing > ------- > > ran all new tasks, except for internal maven publishing > > Notes: > - To try it out you can call ./gradlew tasks --all to see all the tasks and > compare them to current tasks/artifacts. > - Replaced cobertura with jacoco, as it's easier/cleaner to configure, easier > to combine all test results into a single report. > - Generated pom.xml now has correct dependencies/versions > - Script generation is currently hardcoded and not based on sqoop help, as > previously - though added the possiblity of hooking it in later > > > Thanks, > > Anna Szonyi > >
