> On 五月 17, 2017, 11:50 a.m., Attila Szabo wrote: > > src/java/org/apache/sqoop/manager/Db2Manager.java > > Lines 372-394 (patched) > > <https://reviews.apache.org/r/58600/diff/1/?file=1696010#file1696010line372> > > > > Could you please check if this has been already solved in other > > connectors? > > > > Getting schema option sounds quite general, might have been implemented > > elsewhere in the codebase. > > > > Would make sense to abstract it out, and just call it from different > > places. > > > > Thanks for checking! > > Ying Cao wrote: > Hi Attila > > Yes, this has been already solved in Postgresql. Which file is suitable > to abstrace it out? > > Attila Szabo wrote: > Hey Angela, > > I would recommend GenericJdbcManager class. > > Cheers, > Attila
Hi Attila, Thanks for your suggestions. I have abstrace it in GenericJdbcManager class Angela - Ying ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/58600/#review175233 ----------------------------------------------------------- On 六月 4, 2017, 4:38 p.m., Ying Cao wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/58600/ > ----------------------------------------------------------- > > (Updated 六月 4, 2017, 4:38 p.m.) > > > Review request for Sqoop, Abraham Elmahrek, Boglarka Egyed, Jarek Cecho, > Attila Szabo, and Szabolcs Vasas. > > > Bugs: SQOOP-1905 > https://issues.apache.org/jira/browse/SQOOP-1905 > > > Repository: sqoop-trunk > > > Description > ------- > > SQOOP-1905 : add --schema option for import-all-tables and list-tables > against db2 > > > Diffs > ----- > > src/java/org/apache/sqoop/manager/Db2Manager.java 52ab05ef > src/java/org/apache/sqoop/manager/GenericJdbcManager.java 2113a5f5 > > src/test/org/apache/sqoop/manager/db2/DB2ImportAllTableWithSchemaManual.java > PRE-CREATION > > > Diff: https://reviews.apache.org/r/58600/diff/3/ > > > Testing > ------- > > Mannual UT is passed > > > Thanks, > > Ying Cao > >
