----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/58600/#review175936 -----------------------------------------------------------
Hi Ying, I tried to run 'ant clean test' with your patch but ran into some compilation errors. Please find the details below. Thanks, Bogi src/test/org/apache/sqoop/manager/db2/DB2ImportAllTableWithSchema.java Lines 73 (patched) <https://reviews.apache.org/r/58600/#comment249275> Could you please include "ManualTest" at the end of this test name to follow the usual naming convention which is also used in the build.xml to create the manual test suite? src/test/org/apache/sqoop/manager/db2/DB2ImportAllTableWithSchema.java Lines 142 (patched) <https://reviews.apache.org/r/58600/#comment249276> This line causes a compilation error because of the ",": error: incompatible types: String cannot be converted to Throwable [javac] LOG.warn("Exception while closing stmt", ex.getMessage()); Please use the exception itself instead of the getMessage - could you please correct it at all the other occasions as well? src/test/org/apache/sqoop/manager/db2/DB2ImportAllTableWithSchema.java Lines 162 (patched) <https://reviews.apache.org/r/58600/#comment249277> This line causes a compilation error because of the ",": error: incompatible types: String cannot be converted to Throwable [javac] LOG.error("Encountered SQL Exception: ", sqlE.getMessage()); src/test/org/apache/sqoop/manager/db2/DB2ImportAllTableWithSchema.java Lines 169 (patched) <https://reviews.apache.org/r/58600/#comment249278> This line causes a compilation error because of the ",": error: incompatible types: String cannot be converted to Throwable [javac] LOG.warn("Exception while closing connection/stmt", ex.getMessage()); - Boglarka Egyed On May 24, 2017, 9:20 a.m., Ying Cao wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/58600/ > ----------------------------------------------------------- > > (Updated May 24, 2017, 9:20 a.m.) > > > Review request for Sqoop, Abraham Elmahrek, Boglarka Egyed, Jarek Cecho, > Attila Szabo, and Szabolcs Vasas. > > > Bugs: SQOOP-1905 > https://issues.apache.org/jira/browse/SQOOP-1905 > > > Repository: sqoop-trunk > > > Description > ------- > > SQOOP-1905 : add --schema option for import-all-tables and list-tables > against db2 > > > Diffs > ----- > > src/java/org/apache/sqoop/manager/Db2Manager.java 52ab05ef > src/test/org/apache/sqoop/manager/db2/DB2ImportAllTableWithSchema.java > PRE-CREATION > > > Diff: https://reviews.apache.org/r/58600/diff/2/ > > > Testing > ------- > > Mannual UT is passed > > > Thanks, > > Ying Cao > >
