> On Jan. 27, 2017, 12:56 p.m., Szabolcs Vasas wrote: > > src/perftest/LobFileStressTest.java, line 154 > > <https://reviews.apache.org/r/55466/diff/1/?file=1603904#file1603904line154> > > > > Since the exception is not caught anymore the code after line 149 will > > not run.
Thanks for the review, Szabi! I have reverted this file as this is a manual performance test and thus should not be included in the scope of this change IMHO. - Boglarka ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/55466/#review163253 ----------------------------------------------------------- On Feb. 25, 2017, 5:46 p.m., Boglarka Egyed wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/55466/ > ----------------------------------------------------------- > > (Updated Feb. 25, 2017, 5:46 p.m.) > > > Review request for Sqoop, Attila Szabo, Anna Szonyi, and Liz Szilagyi. > > > Bugs: SQOOP-3100 > https://issues.apache.org/jira/browse/SQOOP-3100 > > > Repository: sqoop-trunk > > > Description > ------- > > Normalizing test cases where we except an exception using JUnit's > ExpectedException rule to make the code more clean and self-explanatory. > > > Diffs > ----- > > src/test/com/cloudera/sqoop/TestIncrementalImport.java > 57f4433d8f50b37f102a8a8ada7196d9287b5557 > src/test/com/cloudera/sqoop/lib/TestRecordParser.java > 57bdb5fe057f74dcaef9e2e3d6e1d26d3af7833a > src/test/com/cloudera/sqoop/metastore/TestSavedJobs.java > 1fb732439dd2c8f187af726935a335c993895bc5 > src/test/com/cloudera/sqoop/orm/TestClassWriter.java > a27353df4ed84a7dfe7612662f3170c00951d2cf > > Diff: https://reviews.apache.org/r/55466/diff/ > > > Testing > ------- > > ant test, ant clean test > > > Thanks, > > Boglarka Egyed > >
