----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/55466/#review162938 -----------------------------------------------------------
Ship it! Thank you for improving our tests! - Liz Szilagyi On Jan. 12, 2017, 7:32 p.m., Boglarka Egyed wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/55466/ > ----------------------------------------------------------- > > (Updated Jan. 12, 2017, 7:32 p.m.) > > > Review request for Sqoop, Attila Szabo, Anna Szonyi, and Liz Szilagyi. > > > Bugs: SQOOP-3100 > https://issues.apache.org/jira/browse/SQOOP-3100 > > > Repository: sqoop-trunk > > > Description > ------- > > Normalizing test cases where we except an exception using JUnit's > ExpectedException rule to make the code more clean and self-explanatory. > > > Diffs > ----- > > src/perftest/LobFileStressTest.java > dafebb423078edc55414fa676c9e0c31b6a725cf > src/test/com/cloudera/sqoop/TestIncrementalImport.java > 57f4433d8f50b37f102a8a8ada7196d9287b5557 > src/test/com/cloudera/sqoop/lib/TestRecordParser.java > 57bdb5fe057f74dcaef9e2e3d6e1d26d3af7833a > src/test/com/cloudera/sqoop/metastore/TestSavedJobs.java > 1fb732439dd2c8f187af726935a335c993895bc5 > src/test/com/cloudera/sqoop/orm/TestClassWriter.java > ea31e9d5a1307e4179d6d21545c10b85c28566e1 > > Diff: https://reviews.apache.org/r/55466/diff/ > > > Testing > ------- > > ant test, ant clean test > > > Thanks, > > Boglarka Egyed > >
