----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/55769/#review166495 -----------------------------------------------------------
Hi Dmitry, Thanks for the patch, looks good! I would second Szabolcs's comment that it would be good to add a test case that covers the "backwards compatibility": using the cleaned column name for mapping with non-avro cases - we checked it out and it shouldn't be a problem, but it would be great to have automated test cases for it. Thanks, /Anna - Anna Szonyi On Jan. 27, 2017, 1:54 p.m., Dmitry Zagorulkin wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/55769/ > ----------------------------------------------------------- > > (Updated Jan. 27, 2017, 1:54 p.m.) > > > Review request for Sqoop, Olivier Lamy and vishnu s nair. > > > Bugs: SQOOP-3123 > https://issues.apache.org/jira/browse/SQOOP-3123 > > > Repository: sqoop-trunk > > > Description > ------- > > Special characters processing in table and column names > > https://issues.apache.org/jira/browse/SQOOP-3123 > > > Diffs > ----- > > src/java/org/apache/sqoop/orm/ClassWriter.java c18a36f3 > src/test/com/cloudera/sqoop/TestAvroImport.java 26edd4ce > > Diff: https://reviews.apache.org/r/55769/diff/ > > > Testing > ------- > > > Thanks, > > Dmitry Zagorulkin > >
