----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/55769/#review166335 -----------------------------------------------------------
Hi Dmitry! Thank you for the patch I looks good to me. I have applied it to trunk and all the tests are running fine. However I have one minor request: can you please add another test case which proves that Sqoop remains backwards compatible with your changes? The users had to provide the cleaned column names in the --map-column-java option earlier it would be very good to have a test which ensures that the patch will not break these old commands. After that I think we could ship the patch. Thanks, Szabolcs - Szabolcs Vasas On Jan. 27, 2017, 1:54 p.m., Dmitry Zagorulkin wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/55769/ > ----------------------------------------------------------- > > (Updated Jan. 27, 2017, 1:54 p.m.) > > > Review request for Sqoop, Olivier Lamy and vishnu s nair. > > > Bugs: SQOOP-3123 > https://issues.apache.org/jira/browse/SQOOP-3123 > > > Repository: sqoop-trunk > > > Description > ------- > > Special characters processing in table and column names > > https://issues.apache.org/jira/browse/SQOOP-3123 > > > Diffs > ----- > > src/java/org/apache/sqoop/orm/ClassWriter.java c18a36f3 > src/test/com/cloudera/sqoop/TestAvroImport.java 26edd4ce > > Diff: https://reviews.apache.org/r/55769/diff/ > > > Testing > ------- > > > Thanks, > > Dmitry Zagorulkin > >
