> On Dec. 7, 2015, 2:41 p.m., Jarek Cecho wrote: > > test/src/main/java/org/apache/sqoop/test/minicluster/SqoopMiniCluster.java, > > lines 211-212 > > <https://reviews.apache.org/r/40635/diff/11/?file=1154866#file1154866line211> > > > > This is just temporary right? I'm assuming that in case that kerberos > > is enabled, we will start the minicluster's in kerberos mode as well?
Correct. This is temporary as this JIRA focus on the kerberos authentication between sqoop client and sqoop server. We will add kerberos support for the whole minicluster in separate JIRA. > On Dec. 7, 2015, 2:41 p.m., Jarek Cecho wrote: > > test/src/main/java/org/apache/sqoop/test/minicluster/JettySqoopMiniCluster.java, > > line 74 > > <https://reviews.apache.org/r/40635/diff/11/?file=1154865#file1154865line74> > > > > Thinking about it, can we perhaps add new configuration option to > > JettyServer that in addition to port will accept also a hostname > > identifying on what interface we should start (with blank as a default)? > > This way, the method "getServerUrl" will return proper hostname instead of > > localhost and hence we would not have to do this monkey patching. > > > > I'm proposing that because this subtitution seems quite fragile to me > > :-(. If you agree, then let's do that in separate JIRA as that is > > standalone functionality that will be useful outside of this patch as well > > :) Good advice. Will do that in separate JIRA. While for this JIRA, what about keeping the current solution as I found that to it's not straightforward to make the configured hostname usable in this patch. For example, we need to know the hostname of the server to create principal for sqoopserver in MiniKdcRunner and so we need to find a way to transfer the configured hostname to MiniKdcRunner. - Dian ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/40635/#review109148 ----------------------------------------------------------- On Dec. 7, 2015, 4:53 a.m., Dian Fu wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/40635/ > ----------------------------------------------------------- > > (Updated Dec. 7, 2015, 4:53 a.m.) > > > Review request for Sqoop. > > > Bugs: SQOOP-2705 > https://issues.apache.org/jira/browse/SQOOP-2705 > > > Repository: sqoop-sqoop2 > > > Description > ------- > > At the first step of providing kerberos support for integration tests, I'd > like to add kerberos support for SqoopMiniCluster make sure the communication > between sqoop client and sqoop server are kerberos enabled. > > > Diffs > ----- > > pom.xml 91721ce > test/pom.xml 4e1e197 > test/src/main/java/org/apache/sqoop/test/infrastructure/SqoopTestCase.java > c1f355f > > test/src/main/java/org/apache/sqoop/test/infrastructure/providers/KdcInfrastructureProvider.java > PRE-CREATION > test/src/main/java/org/apache/sqoop/test/kdc/KdcRunner.java PRE-CREATION > test/src/main/java/org/apache/sqoop/test/kdc/KdcRunnerFactory.java > PRE-CREATION > test/src/main/java/org/apache/sqoop/test/kdc/MiniKdcRunner.java > PRE-CREATION > test/src/main/java/org/apache/sqoop/test/kdc/NoKerberosKdcRunner.java > PRE-CREATION > > test/src/main/java/org/apache/sqoop/test/minicluster/JettySqoopMiniCluster.java > 325a790 > test/src/main/java/org/apache/sqoop/test/minicluster/SqoopMiniCluster.java > 9ae941f > test/src/main/java/org/apache/sqoop/test/testcases/JettyTestCase.java > bd4ba6a > test/src/main/java/org/apache/sqoop/test/utils/KerberosTestUtils.java > PRE-CREATION > test/src/main/java/org/apache/sqoop/test/utils/SqoopUtils.java 5964bcd > > test/src/test/java/org/apache/sqoop/integration/server/InformalObjectNameTest.java > fe04df7 > > test/src/test/java/org/apache/sqoop/integration/server/ShowJobInOrderTest.java > 298ec09 > > test/src/test/java/org/apache/sqoop/integration/server/SubmissionWithDisabledModelObjectsTest.java > c2709a7 > test/src/test/java/org/apache/sqoop/integration/server/VersionTest.java > e86a6cc > test/src/test/java/org/apache/sqoop/integration/server/rest/RestTest.java > 20f09e8 > > Diff: https://reviews.apache.org/r/40635/diff/ > > > Testing > ------- > > > Thanks, > > Dian Fu > >
