----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/40635/#review109148 -----------------------------------------------------------
1) The path no longer applies cleanly sadly :( It will need rebase. test/src/main/java/org/apache/sqoop/test/infrastructure/SqoopTestCase.java (lines 104 - 105) <https://reviews.apache.org/r/40635/#comment168597> Would you mind describing why changing the SqoopClient to static? test/src/main/java/org/apache/sqoop/test/infrastructure/SqoopTestCase.java (line 127) <https://reviews.apache.org/r/40635/#comment168598> Would you mind describing why changing the startInfrastructureProviders method to static? test/src/main/java/org/apache/sqoop/test/infrastructure/SqoopTestCase.java (line 317) <https://reviews.apache.org/r/40635/#comment168600> Would you mind describing why changing the getSqoopServerUrl() to static? test/src/main/java/org/apache/sqoop/test/infrastructure/SqoopTestCase.java (lines 342 - 343) <https://reviews.apache.org/r/40635/#comment168601> Can we move this functionality to the provider itself rather then using the KerberosTestUtils directly? We have instance of the provider here, so we can move those method there. test/src/main/java/org/apache/sqoop/test/minicluster/JettySqoopMiniCluster.java (line 73) <https://reviews.apache.org/r/40635/#comment168603> Thinking about it, can we perhaps add new configuration option to JettyServer that in addition to port will accept also a hostname identifying on what interface we should start (with blank as a default)? This way, the method "getServerUrl" will return proper hostname instead of localhost and hence we would not have to do this monkey patching. I'm proposing that because this subtitution seems quite fragile to me :-(. If you agree, then let's do that in separate JIRA as that is standalone functionality that will be useful outside of this patch as well :) test/src/main/java/org/apache/sqoop/test/minicluster/SqoopMiniCluster.java (lines 211 - 212) <https://reviews.apache.org/r/40635/#comment168606> This is just temporary right? I'm assuming that in case that kerberos is enabled, we will start the minicluster's in kerberos mode as well? test/src/main/java/org/apache/sqoop/test/utils/KerberosTestUtils.java (line 40) <https://reviews.apache.org/r/40635/#comment168607> Since most of the implementation of this util class is relevant only to the MiniKdcRunner, let's move that code to this runner (to have all the relevant code on one place). Jarcec - Jarek Cecho On Dec. 7, 2015, 4:53 a.m., Dian Fu wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/40635/ > ----------------------------------------------------------- > > (Updated Dec. 7, 2015, 4:53 a.m.) > > > Review request for Sqoop. > > > Bugs: SQOOP-2705 > https://issues.apache.org/jira/browse/SQOOP-2705 > > > Repository: sqoop-sqoop2 > > > Description > ------- > > At the first step of providing kerberos support for integration tests, I'd > like to add kerberos support for SqoopMiniCluster make sure the communication > between sqoop client and sqoop server are kerberos enabled. > > > Diffs > ----- > > pom.xml 91721ce > test/pom.xml 4e1e197 > test/src/main/java/org/apache/sqoop/test/infrastructure/SqoopTestCase.java > c1f355f > > test/src/main/java/org/apache/sqoop/test/infrastructure/providers/KdcInfrastructureProvider.java > PRE-CREATION > test/src/main/java/org/apache/sqoop/test/kdc/KdcRunner.java PRE-CREATION > test/src/main/java/org/apache/sqoop/test/kdc/KdcRunnerFactory.java > PRE-CREATION > test/src/main/java/org/apache/sqoop/test/kdc/MiniKdcRunner.java > PRE-CREATION > test/src/main/java/org/apache/sqoop/test/kdc/NoKerberosKdcRunner.java > PRE-CREATION > > test/src/main/java/org/apache/sqoop/test/minicluster/JettySqoopMiniCluster.java > 325a790 > test/src/main/java/org/apache/sqoop/test/minicluster/SqoopMiniCluster.java > 9ae941f > test/src/main/java/org/apache/sqoop/test/testcases/JettyTestCase.java > bd4ba6a > test/src/main/java/org/apache/sqoop/test/utils/KerberosTestUtils.java > PRE-CREATION > test/src/main/java/org/apache/sqoop/test/utils/SqoopUtils.java 5964bcd > > test/src/test/java/org/apache/sqoop/integration/server/InformalObjectNameTest.java > fe04df7 > > test/src/test/java/org/apache/sqoop/integration/server/ShowJobInOrderTest.java > 298ec09 > > test/src/test/java/org/apache/sqoop/integration/server/SubmissionWithDisabledModelObjectsTest.java > c2709a7 > test/src/test/java/org/apache/sqoop/integration/server/VersionTest.java > e86a6cc > test/src/test/java/org/apache/sqoop/integration/server/rest/RestTest.java > 20f09e8 > > Diff: https://reviews.apache.org/r/40635/diff/ > > > Testing > ------- > > > Thanks, > > Dian Fu > >
