> On Feb. 17, 2015, 7:52 p.m., Veena Basavaraj wrote: > > pom.xml, line 475 > > <https://reviews.apache.org/r/31127/diff/1/?file=866485#file866485line475> > > > > does not this need a license update? if so please indicate that and not > > sure if we need a new RB to update LICENSE.txt
Ideally we should update LICENSE.txt file for every jar that we are shipping. Currently this is not done for several of them. We should do it, but it doesn't seem blocker for 1.99.5 and hence I did not do this exercise as part of this patch. - Jarek ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/31127/#review72769 ----------------------------------------------------------- On Feb. 17, 2015, 7:57 p.m., Jarek Cecho wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/31127/ > ----------------------------------------------------------- > > (Updated Feb. 17, 2015, 7:57 p.m.) > > > Review request for Sqoop. > > > Bugs: SQOOP-2109 > https://issues.apache.org/jira/browse/SQOOP-2109 > > > Repository: sqoop-sqoop2 > > > Description > ------- > > There has been several things that I had to fix in order to get this right: > > * Shell packaging was pulling in all dependencies regardless of their scope, > I had to manually switch it from "test" to "runtime" > * Common was directly depending on common-test without properly specifying > testing scope > * Security module was completely missing dependency on com.bueust (that > wasn't problem because 2) has pulled it in transitively) > > > Diffs > ----- > > common/pom.xml 9e593b2 > pom.xml d48389e > security/pom.xml e4e61cc > shell/pom.xml e48c86a > > Diff: https://reviews.apache.org/r/31127/diff/ > > > Testing > ------- > > I've run the packaging target and the shell/lib directory size decreased from > 46MB to 28MB (almost a half!), excluding all the testing dependencies. > > > Thanks, > > Jarek Cecho > >
